Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26F14EA5F for ; Thu, 29 Nov 2012 19:36:59 +0000 (UTC) Received: (qmail 37074 invoked by uid 500); 29 Nov 2012 19:36:58 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 37013 invoked by uid 500); 29 Nov 2012 19:36:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36869 invoked by uid 99); 29 Nov 2012 19:36:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Nov 2012 19:36:58 +0000 Date: Thu, 29 Nov 2012 19:36:58 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@hbase.apache.org Message-ID: <1400174951.41566.1354217818687.JavaMail.jiratomcat@arcas> In-Reply-To: <696365875.41555.1354217699684.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (HBASE-7237) system metadata for tables/cfs needs to be validated on the master MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HBASE-7237: ------------------------------------ Description: shell currently validates whatever metadata user provides as argument to alter, however while looking at some other issue I noticed that user and system metadata is stored in the same dictionary in the descriptor, so shell validation is easy to bypass by setting a "user" metadata parameter with the same name as the system parameter. E.g. I just set MAX_FILESIZE to "moo" via CONFIG. This can be fixed in the shell, however the general problem I think is that system configuration should be validated server-side (e.g. on the master), not just on the client. was: shell currently validates what used provides with alter, however while looking at some other issue I noticed that user and system metadata is stored in the same dictionary on the server, so it is easy to bypass by setting a "user" metadata parameter with the same name as the system parameter. E.g. I just set MAX_FILESIZE to "moo" via CONFIG. This can be fixed in the shell, however the general problem I think is that system configuration should be validated server-side (e.g. on the master), not just on the client. > system metadata for tables/cfs needs to be validated on the master > ------------------------------------------------------------------ > > Key: HBASE-7237 > URL: https://issues.apache.org/jira/browse/HBASE-7237 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.96.0 > Reporter: Sergey Shelukhin > Priority: Minor > > shell currently validates whatever metadata user provides as argument to alter, however while looking at some other issue I noticed that user and system metadata is stored in the same dictionary in the descriptor, so shell validation is easy to bypass by setting a "user" metadata parameter with the same name as the system parameter. > E.g. I just set MAX_FILESIZE to "moo" via CONFIG. > This can be fixed in the shell, however the general problem I think is that system configuration should be validated server-side (e.g. on the master), not just on the client. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira