hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7110) refactor the compaction selection and config code similarly to 0.89-fb changes
Date Wed, 21 Nov 2012 02:32:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501667#comment-13501667
] 

Enis Soztutar commented on HBASE-7110:
--------------------------------------

Overall looks good. Some points: 
 - I think HStore.getTtl() should just returns the configured this.ttl, and should not look
at min versions. Looking at min versions only apply at the compaction selection for expiry.

 - Some lines exceed 100 chars. 
 - Checked whether the current compaction policy is unchanged with this patch. Although there
are some refactorings and splitting up the work, it seems so. 


                
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-7110
>                 URL: https://issues.apache.org/jira/browse/HBASE-7110
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7110-v6-squashed.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after code review)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message