hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7109) integration tests on cluster are not getting picked up from distribution
Date Fri, 09 Nov 2012 23:25:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494417#comment-13494417

Ted Yu commented on HBASE-7109:

+  private List<Class<?>> findClassesFromJar(String jarFileName, String packageName,
boolean proceedOnExceptions)
The above line is too long (> 100 chars).
+        String className = packageName + '.' + fileName.substring(0, fileName.length() -
The above line is long. Consider introducing a constant for ".class".length() which appears
in two places.

ClassFinder is in src/test. People would think that it is used to find test classes.
+public class ClassTestFinder extends ClassFinder {
ClassTestFinder is the class that gets instantiated in the patch. Is it possible to unify
the two classes ?

> integration tests on cluster are not getting picked up from distribution
> ------------------------------------------------------------------------
>                 Key: HBASE-7109
>                 URL: https://issues.apache.org/jira/browse/HBASE-7109
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7109-squashed.patch, HBASE-7109-v2-squashed.patch, HBASE-7109-v3-squashed.patch
> The method of finding test classes only works on local build (or its full copy), not
if the distribution is used.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message