hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7185) Create hbase-rpc module
Date Tue, 20 Nov 2012 18:29:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501356#comment-13501356
] 

stack commented on HBASE-7185:
------------------------------

Highlevel, this is rpc module so why the pb stuff in here?  Its scope is messy when it has
stuff like ClusterIdProtos and AggregateProtos and zk protos?
Did you have to pull in stuff to make things like AggregateProtos happy?

Is it odd having RegionServerProto in here, in this module that hbase-server, another module
downstream on the dependency river, depends on?

Any particular reason you need it beyond what is listed in issue?

It does not move the content of the rpc package?  Just the pbs?


So the below makes it so I can skip unit tests in rpc?

<id>skip-rpc-tests</id>

Its a profile?  -Pskip-rpc-tests  Or I do it w/ -Dskip-rpc-tests=true

Should be in release notes how to do above.

If above is correct, why doesn't skipTests work for this module?  It does but you just want
flag for skipping rpcs?

                
> Create hbase-rpc module
> -----------------------
>
>                 Key: HBASE-7185
>                 URL: https://issues.apache.org/jira/browse/HBASE-7185
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from
a server) will be stored.  This should allow others to create clients without relying on too
much of the hbase code base.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message