hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6721) RegionServer Group based Assignment
Date Mon, 05 Nov 2012 18:34:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490800#comment-13490800

Ted Yu commented on HBASE-6721:

In SecureGroupAdminEndpoint, the following code is called repeatedly:
+  private AccessController getAccessController() {
+    return (AccessController)menv.getMasterServices()
+        .getCoprocessorHost().findCoprocessor(AccessController.class.getName());
+  }
Should AccessController be stored in a field variable ?
For TestSecureGroupAdminEndpoint:
+  @Test
+  public void testGetAddRemove() throws Exception {
Would testGroupGetterAdditionRemoval() be better name for the above method ?
For GroupAdmin interface:

+   * List servers that are currently being moved to a new group
+   * @return
+   * @throws IOException
+   */
+  Map<String, String> listServersInTransition() throws IOException;
Please describe the meaning of key and value in the returned Map.
For GroupAdminClient.java:
+      for(String server: proxy.listServersInTransition().keySet()) {
+        found = found || servers.contains(server);
+      }
+      Thread.sleep(1000);
We can break out of the for loop once found becomes true, right ?
Would suggest using a shorter sleep interval above.
For DefaultLoadBalancer.java:
-  public ServerName randomAssignment(List<ServerName> servers) {
+  public ServerName randomAssignment(HRegionInfo region, List<ServerName> servers)
The new parameter region is not used. We don't need to introduce this parameter, right ?
BTW StochasticLoadBalancer doesn't have randomAssignment().

Will provide more comments for next patch.
> RegionServer Group based Assignment
> -----------------------------------
>                 Key: HBASE-6721
>                 URL: https://issues.apache.org/jira/browse/HBASE-6721
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Francis Liu
>            Assignee: Vandana Ayyalasomayajula
>             Fix For: 0.96.0
>         Attachments: HBASE-6721_94_2.patch, HBASE-6721_94.patch, HBASE-6721_94.patch,
> In multi-tenant deployments of HBase, it is likely that a RegionServer will be serving
out regions from a number of different tables owned by various client applications. Being
able to group a subset of running RegionServers and assign specific tables to it, provides
a client application a level of isolation and resource allocation.
> The proposal essentially is to have an AssignmentManager which is aware of RegionServer
groups and assigns tables to region servers based on groupings. Load balancing will occur
on a per group basis as well. 
> This is essentially a simplification of the approach taken in HBASE-4120. See attached

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message