hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7097) Log message in SecureServer.class uses wrong class name
Date Mon, 05 Nov 2012 22:06:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490975#comment-13490975

Gary Helmling commented on HBASE-7097:

This was unfortunately intentional, at least in the {{LOG}} instance, in order to provide
an admittedly cludgey way to enable debug logging for the entire org.apache.hadoop.hbase logger
without spamming region server logs with per-request messages -- per request metrics only
get logged if you enable debug logging for org.apache.hadoop.ipc. It preserves the same technique
that is used in HBaseServer.

No argument from me that the technique is ugly.  But if we actually fix the logger to use
the correct class name, we should also change per-request logging to only happen at trace
level instead of debug, so that existing HBase setups with debug level enabled for the org.apache.hadoop.hbase
parent don't start getting noisy per-request messages.
> Log message in SecureServer.class uses wrong class name
> -------------------------------------------------------
>                 Key: HBASE-7097
>                 URL: https://issues.apache.org/jira/browse/HBASE-7097
>             Project: HBase
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.92.2, 0.94.2
>            Reporter: Y. SREENIVASULU REDDY
>            Priority: Minor
>             Fix For: 0.92.3, 0.94.3
>         Attachments: HBASE-7097_94.patch
> log messages are printing wrongly in org.apache.hadoop.hbase.ipc.SecureServer.class 
> {code}
> public static final Log LOG = LogFactory.getLog("org.apache.hadoop.ipc.SecureServer");

>   private static final Log AUDITLOG = 
>     LogFactory.getLog("SecurityLogger.org.apache.hadoop.ipc.SecureServer"); 
> {code}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message