hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7208) Transition Offline Snapshots to ExternalExceptions
Date Mon, 26 Nov 2012 22:32:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504190#comment-13504190

Jonathan Hsieh commented on HBASE-7208:

This looks like a big patch but most of it is mechanical due to a renames.   Highlights of
what has been done:

* Removed old error handling framework, many renames (HBaseException -> ExtenralException,
failOnError -> rethrowException)
* Moved the body of snapshot functions into the SnapshotManager.  Better encapsulation and
makes exception layering much clearer (HMaster throws SerivceExceptions, SnapshotManager throws
IO and HBaseSnapshot exn).
* Added cancel method to SnapshotSentinel
* Refactored DisabledTableSnapshotHandler into TakeSnapshotHandler (This is the online-scaffolding
patch essentially)
* Converted *Task to Callable<Void> instead of Runnable so that Exceptions can be thrown
normally if called in line and centralized use of the ExternalException infra to only where

Compared to previous version -- there are no generics, fewer classes, more straightforward
errorhandling, and better encapsulation of snapshotting methods within the SnapshotManager.

> Transition Offline Snapshots to ExternalExceptions
> --------------------------------------------------
>                 Key: HBASE-7208
>                 URL: https://issues.apache.org/jira/browse/HBASE-7208
>             Project: HBase
>          Issue Type: Sub-task
>          Components: snapshots
>    Affects Versions: hbase-6055
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: hbase-6055
>         Attachments: hbase-7208.v6.patch
> This will eliminate the old errorhandling code, and update existing code to use the ExternalException
> I'd like this to be done before attempt merging to trunk.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message