hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
Date Tue, 06 Nov 2012 04:08:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491196#comment-13491196
] 

Lars Hofhansl commented on HBASE-7009:
--------------------------------------

I do not think that ever worked correctly. Note that before HBASE-5058 masterChecked was always
set to true. That patch there just maintained that behavior.
Looking at the code I actually do not quite understand what masterChecked is supposed to prevent
against... Repeatedly checking the master if the master is actually down?

HBASE-5058 fixes that for unmanaged connections (those created directly and not indirectly
through an HTable).

I think we can just remove that masterChecked logic. But, I do not want to touch that code
on short notice (not for 0.94.3). In the past this code has proven to be extremely fragile.

                
> Port HBaseCluster interface/tests to 0.94
> -----------------------------------------
>
>                 Key: HBASE-7009
>                 URL: https://issues.apache.org/jira/browse/HBASE-7009
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 0.94.3
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.94.4
>
>         Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch
>
>
> Need to port. I am porting V5 patch from the original JIRA; I have a partially ported
(V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message