hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7062) Move HLog stats to metrics 2
Date Fri, 09 Nov 2012 02:24:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493685#comment-13493685
] 

Ted Yu commented on HBASE-7062:
-------------------------------

MetricsHLogSource.java and TestMetricsHLogSource.java are missing license header.
{code}
+public interface MetricsHLogSource extends BaseSource {
{code}
Add annotation for audience. Same with MetricsHLogSourceImpl.java
{code}
+   * Add the time it to to append to a histogram.
+   */
+  void incrementAppendTime(long time);
{code}
I guess what you wanted to say was 'it took to'

                
> Move HLog stats to metrics 2
> ----------------------------
>
>                 Key: HBASE-7062
>                 URL: https://issues.apache.org/jira/browse/HBASE-7062
>             Project: HBase
>          Issue Type: Sub-task
>          Components: metrics
>    Affects Versions: 0.96.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7062-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message