hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7185) Create hbase-protocol module
Date Wed, 21 Nov 2012 20:05:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502261#comment-13502261
] 

Gary Helmling commented on HBASE-7185:
--------------------------------------

It looks like some PB generated sources are still under hbase-server:
{noformat}
$ find hbase-server/ -name '*Protos.java'
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/BulkDeleteProtos.java
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/ExampleProtos.java
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestDelayedRpcProtos.java
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestRpcServiceProtos.java
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestProtos.java
{noformat}

The .proto files for the {{Test*}} classes are still under {{hbase-server}}, so these seem
okay:
{noformat}
$ ls hbase-server/src/test/protobuf/
test_delayed_rpc.proto  test.proto  test_rpc_service.proto
{noformat}

But the {{BulkDelete.proto}} and {{Examples.proto}} files were moved under {{hbase-protocol}},
so it seems like their {{*Protos.java}} files should be moved as well.  Just wanted to confirm
there wasn't a reason these were left behind.  If not, I'll open an issue.

                
> Create hbase-protocol module
> ----------------------------
>
>                 Key: HBASE-7185
>                 URL: https://issues.apache.org/jira/browse/HBASE-7185
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7185-0.patch, HBASE-7185-1.patch, HBASE-7185-2.patch
>
>
> Create an hbase-rpc module where protobuf's that can cross the wire(either to zk or from
a server) will be stored.  This should allow others to create clients without relying on too
much of the hbase code base.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message