hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Date Thu, 29 Nov 2012 22:54:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506907#comment-13506907

Elliott Clark commented on HBASE-7232:

* In HBaseObjectWritable is it cleaner to just increment the code (like on line 258) rather
than putting Object in the map ?
* Would having separate implementations of the HFile.FileInfo with different reader methods
be worth it ? ( hfilev1 and hvile <=v2.1 would have the writable.  Everything else uses
the pb.  Could make removing writable version easier later)
* HFileWriterV2 is a white space only change is that intended ?

Some thoughts about code this patch happens to touch:
* Seems like most of the CompoundBloomFilter classes belong in io.  Worth moving them now
* Should CompoundBloomFilterWriter#cacheOnWrite() be renamed to getCacheOnWrite ?
> Remove HbaseMapWritable
> -----------------------
>                 Key: HBASE-7232
>                 URL: https://issues.apache.org/jira/browse/HBASE-7232
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: 7232.txt, 7232.txt, 7232v2.txt
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message