hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7137) Improve Bytes to accept byte buffers which don't allow us to directly access their backing arrays
Date Wed, 14 Nov 2012 11:58:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497040#comment-13497040
] 

Hudson commented on HBASE-7137:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #260 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/260/])
    HBASE-7137 Improve Bytes to accept byte buffers which don't allow us to directly access
their backing arrays (Hiroshi) (Revision 1409148)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java

                
> Improve Bytes to accept byte buffers which don't allow us to directly access their backing
arrays
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7137
>                 URL: https://issues.apache.org/jira/browse/HBASE-7137
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Hiroshi Ikeda
>            Assignee: Hiroshi Ikeda
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7137.patch, HBASE-7137-V2.patch, HBASE-7137-V3.patch
>
>
> Inside HBase, it seems that there is the implicit assumption that byte buffers have backed
arrays and are not read-only, and we can freely call ByteBuffer.array() and arrayOffset()
without runtime exceptions.
> But some classes, including Bytes, are supposed to be used by users from outside of HBase,
and we should think the possibility that methods receive byte buffers which don't hold the
assumption.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message