hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7232) Remove HbaseMapWritable
Date Fri, 30 Nov 2012 06:08:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507130#comment-13507130
] 

Lars Hofhansl commented on HBASE-7232:
--------------------------------------

Patch looks good.

Personally I have no problem with HBaseMapWritable. It will always just write a generic Map
to which we can add (and remove) any field we want, and it is only used with byte[] keys and
values, so nothing really gained by protobuf'ing it.

I'd be happy to change it from a generic to a concrete-type class that only allows byte[]
keys and values. I think it'll make it easier to use HFiles in isolation.

(But nothing against the patch either)

                
> Remove HbaseMapWritable
> -----------------------
>
>                 Key: HBASE-7232
>                 URL: https://issues.apache.org/jira/browse/HBASE-7232
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: 7232.txt, 7232.txt, 7232v2.txt, 7232v3.txt, 7232v4.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message