hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable
Date Tue, 27 Nov 2012 08:21:59 GMT

     [ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Lars Hofhansl updated HBASE-7215:

    Attachment: 7215-v2.txt

Patch that at least passes TestFromClientSide. Also removes Writable from Action, MultiAction,
and MultiResponse.

In general I am quite disappointed about the current state of protobuf'ing work.
This looks unprofessional, where somebody just lost interest in finishing the cleanup work.
We can do better than this.

The Writable stuff is still *all over* the place, sometimes mixed together with the protobuf
stuff (as in the case that I fixed where the Result was serialized as a Writable inside the
protobuf response).

Why is HBaseObjectWritable still around?
I will only believe that we protobuf'ed everything when HBaseObjectWritable is gone for good.

(Sorry for the rant)

> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>                 Key: HBASE-7215
>                 URL: https://issues.apache.org/jira/browse/HBASE-7215
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Blocker
>             Fix For: 0.96.0
>         Attachments: 7215-v2.txt, 7251-SKETCH.txt
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message