hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gustavo Anatoly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7106) [89-fb] Fix the NPE in unit tests for JDK7
Date Thu, 08 Nov 2012 13:53:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493176#comment-13493176

Gustavo Anatoly commented on HBASE-7106:

Hi, Liyin.

I understood your idea, but I'm confused how to replace NULL qualifier when [ -Pjdk7 ] profile
is executed. I did think if when running profile we would have a separted package with specific
test to JDK 7, using HConstants.EMPTY_BYTE_ARRAY.

Could you explain me, please?

> [89-fb] Fix the NPE in unit tests for JDK7
> ------------------------------------------
>                 Key: HBASE-7106
>                 URL: https://issues.apache.org/jira/browse/HBASE-7106
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Priority: Trivial
> In JDK7, it will throw out NPE if put a NULL into a TreeSet. And in the unit tests, user
can add a NULL as qualifier into the family map for GET or SCAN. 
> So we shall do the followings: 
> 1) Make sure the semantics of NULL column qualifier is equal to that of the EMPYT_BYTE_ARRAY
column qualifier.
> 2) An easy fix is to use the EMPYT_BYTE_ARRAY qualifier to replace NULL qualifier in
the family map for the GET or SCAN objects, and everything else shall be backward compatible.
> 3) Add a jdk option in the pom.xml (Assuming user installed the fb packaged jdk)
> eg: mvn test -Dtest=TestFromClientSide -Pjdk7

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message