Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 5 Oct 2012 10:31:47 +1100 (NCT)
From: "Devaraj Das (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <947844644.2950.1349393507877.JavaMail.jiratomcat@arcas>
In-Reply-To: <214061940.64423.1347386047441.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (HBASE-6758) [replication] The
 replication-executor should make sure the file that it is replicating is
 closed before declaring success on that file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HBASE-6758:
-------------------------------

    Attachment: 6758-trunk-3.patch

Attaching a more complete patch based on the new approach .. The changes done to ReplicationSource.java in the earlier patch to do with "fileInUse" is still needed here (I renamed the variable "fileInUse" to be more reflective of what it actually is used for though).
                
> [replication] The replication-executor should make sure the file that it is replicating is closed before declaring success on that file
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6758
>                 URL: https://issues.apache.org/jira/browse/HBASE-6758
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 6758-1-0.92.patch, 6758-2-0.92.patch, 6758-trunk-1.patch, 6758-trunk-2.patch, 6758-trunk-3.patch, TEST-org.apache.hadoop.hbase.replication.TestReplication.xml
>
>
> I have seen cases where the replication-executor would lose data to replicate since the file hasn't been closed yet. Upon closing, the new data becomes visible. Before that happens the ZK node shouldn't be deleted in ReplicationSourceManager.logPositionAndCleanOldLogs. Changes need to be made in ReplicationSource.processEndOfFile as well (currentPath related).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira