Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 22 Oct 2012 16:12:13 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <467401583.10222.1350922333137.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <955272698.65661.1327301501704.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5257) Allow filter to be evaluated after
 version handling
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481462#comment-13481462 ] 

Ted Yu commented on HBASE-5257:
-------------------------------

bq. 4) Finally modify ColumnPaginationFilter to return SEEK_NEXT_COL,INCLUDE_AND_SEEK_NEXT_COL instead of SKIP,INCLUDE_AND_SEEK_NEXT_COL respectively. Similarly for ColumnCountGetFilter
I guess you meant this:
4) Finally modify ColumnPaginationFilter to return SEEK_NEXT_COL,INCLUDE_AND_SEEK_NEXT_COL instead of SKIP,SEEK_NEXT_COL respectively. Similarly for ColumnCountGetFilter

@Varun:
If you can provide a patch as you outlined above, that would be nice.
                
> Allow filter to be evaluated after version handling
> ---------------------------------------------------
>
>                 Key: HBASE-5257
>                 URL: https://issues.apache.org/jira/browse/HBASE-5257
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>
> There are various usecases and filter types where evaluating the filter before version are handled either do not make sense, or make filter handling more complicated.
> Also see this comment in ScanQueryMatcher:
> {code}
>     /**
>      * Filters should be checked before checking column trackers. If we do
>      * otherwise, as was previously being done, ColumnTracker may increment its
>      * counter for even that KV which may be discarded later on by Filter. This
>      * would lead to incorrect results in certain cases.
>      */
> {code}
> So we had Filters after the column trackers (which do the version checking), and then moved it.
> Should be at the discretion of the Filter.
> Could either add a new method to FilterBase (maybe excludeVersions() or something). Or have a new Filter wrapper (like WhileMatchFilter), that should only be used as outmost filter and indicates the same (maybe ExcludeVersionsFilter).
> See latest comments on HBASE-5229 for motivation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira