Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 75D75DB8E for ; Thu, 18 Oct 2012 23:52:08 +0000 (UTC) Received: (qmail 56921 invoked by uid 500); 18 Oct 2012 23:52:08 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 56890 invoked by uid 500); 18 Oct 2012 23:52:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 56881 invoked by uid 99); 18 Oct 2012 23:52:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Oct 2012 23:52:08 +0000 Date: Thu, 18 Oct 2012 23:52:08 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: <406706540.66774.1350604328229.JavaMail.jiratomcat@arcas> In-Reply-To: <214061940.64423.1347386047441.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HBASE-6758) [replication] The replication-executor should make sure the file that it is replicating is closed before declaring success on that file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479499#comment-13479499 ] stack commented on HBASE-6758: ------------------------------ That would explain it (I missed that it was a move... its been at least a week since I reviewed patches... forgive me). > [replication] The replication-executor should make sure the file that it is replicating is closed before declaring success on that file > --------------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-6758 > URL: https://issues.apache.org/jira/browse/HBASE-6758 > Project: HBase > Issue Type: Bug > Reporter: Devaraj Das > Assignee: Devaraj Das > Priority: Critical > Fix For: 0.94.3, 0.96.0 > > Attachments: 6758-0.94.txt, 6758-1-0.92.patch, 6758-2-0.92.patch, 6758-trunk-1.patch, 6758-trunk-2.patch, 6758-trunk-3.patch, 6758-trunk-4.patch, TEST-org.apache.hadoop.hbase.replication.TestReplication.xml > > > I have seen cases where the replication-executor would lose data to replicate since the file hasn't been closed yet. Upon closing, the new data becomes visible. Before that happens the ZK node shouldn't be deleted in ReplicationSourceManager.logPositionAndCleanOldLogs. Changes need to be made in ReplicationSource.processEndOfFile as well (currentPath related). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira