Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D7A47D0AC for ; Tue, 30 Oct 2012 05:30:16 +0000 (UTC) Received: (qmail 35366 invoked by uid 500); 30 Oct 2012 05:30:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 34526 invoked by uid 500); 30 Oct 2012 05:30:15 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 34412 invoked by uid 99); 30 Oct 2012 05:30:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Oct 2012 05:30:15 +0000 Date: Tue, 30 Oct 2012 05:30:15 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <401173939.42989.1351575015385.JavaMail.jiratomcat@arcas> In-Reply-To: <506152063.40163.1351535412663.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HBASE-7060) Region load balancing by table does not handle the case where a table's region count is lower than the number of the RS in the cluster MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486663#comment-13486663 ] Ted Yu commented on HBASE-7060: ------------------------------- Here is result for 0.92 test suite: {code} Failed tests: queueFailover(org.apache.hadoop.hbase.replication.TestReplication): Waited too much time for queueFailover replication. Waited 44939ms. Tests run: 1161, Failures: 1, Errors: 0, Skipped: 8 [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2:00:37.302s {code} The test failure was not related to the patch. > Region load balancing by table does not handle the case where a table's region count is lower than the number of the RS in the cluster > -------------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-7060 > URL: https://issues.apache.org/jira/browse/HBASE-7060 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.92.0 > Reporter: Tianying Chang > Assignee: Ted Yu > Fix For: 0.92.3, 0.94.3 > > Attachments: 7060-94.txt, HBASE-7060.patch > > > When the table's region count is less than the count of region servers, the region balance algorithm will not move the region. For example, the cluster has 100 RS, the table has 50 regions sitting on one RS, they will not be moved to any of the other 99 RS. > This is because the algorithm did not calculate the under-loaded RS correctly. This is how the algorithm works with the above example: > avg-regions-per-RS=0.5 > min-RS-per-RS=0 > max-RS-per-RS=1 > when they calculate the under loaded RS, the code is as below. Since regionCount=0, which is always >=min, so it will always skip, therefore, no underloaded RS are found. > Map underloadedServers = new HashMap(); > for (Map.Entry> server: > serversByLoad.entrySet()) { > int regionCount = server.getKey().getLoad(); > if (regionCount >= min) { break; } > underloadedServers.put(server.getKey().getServerName(), min - regionCount); > } > Later the function returns since underloaded RS size is 0 > if (serverUnerloaded ==0) return regionsToReturn; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira