Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 3 Oct 2012 04:15:07 +1100 (NCT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1987948821.155195.1349198107698.JavaMail.jiratomcat@arcas>
In-Reply-To: <1859266452.155178.1349197627909.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-6920) On timeout connecting to master,
 client can get stuck and never make progress
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467874#comment-13467874 ] 

Hadoop QA commented on HBASE-6920:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547405/HBASE-6920.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2986//console

This message is automatically generated.
                
> On timeout connecting to master, client can get stuck and never make progress
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6920
>                 URL: https://issues.apache.org/jira/browse/HBASE-6920
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.2
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Critical
>         Attachments: HBASE-6920.patch
>
>
> HBASE-5058 appears to have introduced an issue where a timeout in HConnection.getMaster() can cause the client to never be able to connect to the master.  So, for example, an HBaseAdmin object can never successfully be initialized.
> The issue is here:
> {code}
> if (tryMaster.isMasterRunning()) {
>   this.master = tryMaster;
>   this.masterLock.notifyAll();
>   break;
> }
> {code}
> If isMasterRunning times out, it throws an UndeclaredThrowableException, which is already not ideal, because it can be returned to the application.
>  But if the first call to getMaster succeeds, it will set masterChecked = true, which makes us never try to reconnect; that is, we will set this.master = null and just throw MasterNotRunningExceptions, without even trying to connect.
> I tried out a 94 client (actually a 92 client with some 94 patches) on a cluster with some network issues, and it would constantly get stuck as described above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira