Return-Path: 
 <issues-return-66675-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C2E42DAC9
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue, 30 Oct 2012 11:06:17 +0000 (UTC)
Received: (qmail 99504 invoked by uid 500); 30 Oct 2012 11:06:17 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 99300 invoked by uid 500); 30 Oct 2012 11:06:14 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 99127 invoked by uid 99); 30 Oct 2012 11:06:12 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Oct 2012 11:06:12 +0000
Date: Tue, 30 Oct 2012 11:06:12 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <185378125.44122.1351595172586.JavaMail.jiratomcat@arcas>
In-Reply-To: <506152063.40163.1351535412663.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (HBASE-7060) Region load balancing by table does
 not handle the case where a table's region count is lower than the number
 of the RS in the cluster
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HBASE-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-7060:
--------------------------

    Attachment: 7060-test-tentative-94.txt

Attached test shows how this patch fixes the problem.
It is tentative because it takes a long time to run the test (due to additional servers spun up):
{code}
[INFO] Total time: 5:32.574s
{code}

                
> Region load balancing by table does not handle the case where a table's region count is lower than the number of the RS in the cluster
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7060
>                 URL: https://issues.apache.org/jira/browse/HBASE-7060
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.92.0
>            Reporter: Tianying Chang
>            Assignee: Ted Yu
>             Fix For: 0.92.3, 0.94.3
>
>         Attachments: 7060-94.txt, 7060-test-tentative-94.txt, HBASE-7060.patch
>
>
> When the table's region count is less than the count of region servers, the region balance algorithm will not move the region. For example, the cluster has 100 RS, the table has 50 regions sitting on one RS, they will not be moved to any of the other 99 RS.
> This is because the algorithm did not calculate the under-loaded RS correctly. This is how the algorithm works with the above example:
> avg-regions-per-RS=0.5
> min-RS-per-RS=0
> max-RS-per-RS=1
> when they calculate the under loaded RS, the code is as below. Since regionCount=0, which is always >=min, so it will always skip, therefore, no underloaded RS are found.
> Map<ServerName, Integer> underloadedServers = new HashMap<ServerName, Integer>();
> for (Map.Entry<ServerAndLoad, List<HRegionInfo>> server:
> serversByLoad.entrySet()) {
> int regionCount = server.getKey().getLoad();
> if (regionCount >= min) { break; }
> underloadedServers.put(server.getKey().getServerName(), min - regionCount);
> }
> Later the function returns since underloaded RS size is 0
> if (serverUnerloaded ==0) return regionsToReturn;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira