Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 19 Oct 2012 19:23:11 +0000 (UTC)
From: "Jesse Yates (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1348204715.2496.1350674591441.JavaMail.jiratomcat@arcas>
In-Reply-To: <1376528513.1233.1349376828316.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-6949) Automatically delete empty
 directories in CleanerChore
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480288#comment-13480288 ] 

Jesse Yates commented on HBASE-6949:
------------------------------------

To follow up on stack's comment, we don't actually have any directory heirarchy for the logs right now - all logs regardless of source (e.g. .logs/[servername]/[hlog]) just get moved to the .oldlogs directory. And since we just added the HFileCleaner there aren't any existing implementations that can be broken by automatically removing empty directories.
                
> Automatically delete empty directories in CleanerChore
> ------------------------------------------------------
>
>                 Key: HBASE-6949
>                 URL: https://issues.apache.org/jira/browse/HBASE-6949
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: hbase-6949-v0.patch, hbase-6949-v1.patch
>
>
> Currently the CleanerChore asks cleaner delegates if both directories and files should be deleted. However, this leads to somewhat odd behavior in some delegates - you don't actually care if the directory hierarchy is preserved, the files; this means you always will delete directories and then implement the logic you actually want for preserving files. Instead we can handle this logic one layer higher in the CleanerChore and let the delegates just worry about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira