hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4583) Integrate RWCC with Append and Increment operations
Date Tue, 30 Oct 2012 18:08:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487078#comment-13487078

Ted Yu commented on HBASE-4583:

Nice effort, Lars.

For 4583-trunk-less-radical.txt:
+   * @return The smallest mvcc readPoint across all the scanners in this
+   * region. Writes newer than this readPoint, are guaranteed not to be seen
+   * by any current scanner.
+   */
+  public long getLargestReadPoint() {
The first line of javadoc doesn't seem to match name of method - smallest in javadoc vs. largest
in method name.
For MemStore.java:
+   * This now only used by tests.
Insert an 'is' between This and now.
    * @param kvs
    * @return change in memstore size
-  public long upsert(Iterable<KeyValue> kvs) {
+  public long upsert(Iterable<KeyValue> kvs, long readpoint) {
Please add javadoc for new parameter readPoint. Same with upsert().
+        if (cur.getType() == KeyValue.Type.Put.getCode() && cur.getMemstoreTS() <
readpoint - 1) {
Why do we need to subtract one from readPoint ? Considering less than is used already.

> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>                 Key: HBASE-4583
>                 URL: https://issues.apache.org/jira/browse/HBASE-4583
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3, 0.96.0
>         Attachments: 4583-trunk-less-radical.txt, 4583-trunk-less-radical-v2.txt, 4583-trunk-radical.txt,
4583-trunk-radical_v2.txt, 4583-trunk-v3.txt, 4583.txt, 4583-v2.txt, 4583-v3.txt, 4583-v4.txt
> Currently Increment and Append operations do not work with RWCC and hence a client could
see the results of multiple such operation mixed in the same Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes to and
from the memstore.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message