hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7014) cleanup 4 minor findbug warings
Date Fri, 19 Oct 2012 17:38:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480161#comment-13480161
] 

stack commented on HBASE-7014:
------------------------------

These are interesting.

Would be good if you could cite the findbugs output that you are addressing.  Would help reviewing.

Why would:

{code}
-    AdminProtocol admin = this.serverConnections.get(sn.toString());
+    AdminProtocol admin = this.serverConnections.get(sn);
{code}

...even compile?

Do you have to update the test-patch.properties under dev-support count now you've fixed a
few?
                
> cleanup 4 minor findbug warings
> -------------------------------
>
>                 Key: HBASE-7014
>                 URL: https://issues.apache.org/jira/browse/HBASE-7014
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: liang xie
>            Assignee: liang xie
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7014.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message