hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Ranganathan (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-7026) Make metrics collection in StoreScanner.java more efficient
Date Mon, 22 Oct 2012 20:52:13 GMT
Karthik Ranganathan created HBASE-7026:
------------------------------------------

             Summary: Make metrics collection in StoreScanner.java more efficient
                 Key: HBASE-7026
                 URL: https://issues.apache.org/jira/browse/HBASE-7026
             Project: HBase
          Issue Type: Sub-task
            Reporter: Karthik Ranganathan
            Assignee: Karthik Ranganathan


Per the benchmarks I ran, the following block of code seems to be inefficient:
StoreScanner.java:
public synchronized boolean next(List<KeyValue> outResult, int limit,
      String metric) throws IOException {
// ...
      // update the counter 
      if (addedResultsSize > 0 && metric != null) {
        HRegion.incrNumericMetric(this.metricNamePrefix + metric, 
            addedResultsSize);
      }
// ...

Removing this block increased throughput by 10%. We should move this to the outer layer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message