hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6970) hbase-deamon.sh creates/updates pid file even when that start failed.
Date Wed, 10 Oct 2012 18:27:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473443#comment-13473443
] 

Lars Hofhansl commented on HBASE-6970:
--------------------------------------

I had to look up "SGTM". Now I am SGTM.  :)

I think the first change we can make safely, namely only write a new pid if the start was
actually successful (nobody will rely on the _wrong_ pid being in the pid file).
The second change (failure return code from the stop) could throw off existing scripts, although
I still think we should make that change.

                
> hbase-deamon.sh creates/updates pid file even when that start failed.
> ---------------------------------------------------------------------
>
>                 Key: HBASE-6970
>                 URL: https://issues.apache.org/jira/browse/HBASE-6970
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>
> We just ran into a strange issue where could neither start nor stop services with hbase-deamon.sh.
> The problem is this:
> {code}
>     nohup nice -n $HBASE_NICENESS "$HBASE_HOME"/bin/hbase \
>         --config "${HBASE_CONF_DIR}" \
>         $command "$@" $startStop > "$logout" 2>&1 < /dev/null &
>     echo $! > $pid
> {code}
> So the pid file is created or updated even when the start of the service failed. The
next stop command will then fail, because the pid file has the wrong pid in it.
> Edit: Spelling and more spelling errors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message