hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianying Chang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-7058) the code for handling when rs.isSplit() inside AM.nodeDeleted is dead code, should be removed
Date Sat, 27 Oct 2012 04:27:12 GMT
Tianying Chang created HBASE-7058:
-------------------------------------

             Summary: the code for handling when rs.isSplit() inside AM.nodeDeleted is dead
code, should be removed
                 Key: HBASE-7058
                 URL: https://issues.apache.org/jira/browse/HBASE-7058
             Project: HBase
          Issue Type: Bug
          Components: master
    Affects Versions: 0.92.1
            Reporter: Tianying Chang
            Assignee: Tianying Chang
            Priority: Minor


I am reading the code related to region split. I feel that this code below in AssignmentManager
seems to be dead code. Because 1) I don't see any place that callls to update the regionState
to be State.SPLIT. 2) for scenario when region has already been split and RS crashed, ServerShutdownHandler
should have already taken care of it. 

Am I missing something here. If not, I would suggest to remove it. 

if (rs.isSplit()) {
LOG.debug("Ephemeral node deleted, regionserver crashed?, " +
"clearing from RIT; rs=" + rs);
regionOffline(rs.getRegion());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message