hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection
Date Thu, 04 Oct 2012 19:07:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469607#comment-13469607
] 

Phabricator commented on HBASE-6943:
------------------------------------

aaiyer has commented on the revision "[jira] [HBASE-6943] [89-fb] Do not catch certain exceptions
trying to get an RS connection".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:1383 Do we need to
do this in other places as well? -- getRegionServer with/without retries?

  Perhaps a good place to do this is to do it in translateException. If we see that the throwable
is one of these bad ones. we can just throw ie again.

REVISION DETAIL
  https://reviews.facebook.net/D5877

BRANCH
  stuck_client_v4

To: Kannan, Liyin, Karthik, JIRA, mbautin
Cc: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc

                
> [89-fb] Do not catch certain exceptions trying to get an RS connection
> ----------------------------------------------------------------------
>
>                 Key: HBASE-6943
>                 URL: https://issues.apache.org/jira/browse/HBASE-6943
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>         Attachments: D5877.1.patch
>
>
> When getting a regionserver connection in 0.89-fb in HBaseClient, we catch all types
of Throwable. I have observed a real case when the client looked stuck. On debugging it turned
out that a NoSuchMethodError was thrown and caught, leaving the connection in an inconsistent
state (initialized socket but null streams). All following attempts resulted in NPEs that
were also caught, and no errors were logged. From the user's perspective the client was just
stuck. The root cause was the absence of a required jar (hence the NoSuchMethodError) but
it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message