hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6930) [89-fb] Avoid acquiring the same row lock repeatedly
Date Wed, 03 Oct 2012 22:19:08 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phabricator updated HBASE-6930:
-------------------------------

    Attachment: D5841.1.patch

mbautin requested code review of "[jira] [HBASE-6930] [89-fb] Fix TestThriftServerLegacy:
notifyAll should be inside synchronized block".
Reviewers: Kannan, Liyin, Karthik, JIRA

  There were a couple of reasons why TestThriftServerLegacy has been failing recently in the
HBase 89-fb branch:
  - rHBASEEIGHTNINEFBBRANCH1393468 was calling notifyAll outside a synchronized block
  - rHBASEEIGHTNINEFBBRANCH1391219 changed the meaning of a null expected value passed to
checkAndMutate but that was not reflected in the Thrift handler

TEST PLAN
  Run TestThriftServerLegacy

REVISION DETAIL
  https://reviews.facebook.net/D5841

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/13833/

To: Kannan, Liyin, Karthik, JIRA, mbautin

                
> [89-fb] Avoid acquiring the same row lock repeatedly
> ----------------------------------------------------
>
>                 Key: HBASE-6930
>                 URL: https://issues.apache.org/jira/browse/HBASE-6930
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Liyin Tang
>         Attachments: D5841.1.patch, D5841.2.patch
>
>
> When processing the multiPut, multiMutations or multiDelete operations, each IPC handler
thread tries to acquire a lock for each row key in these batches. If there are duplicated
row keys in these batches, previously the IPC handler thread will repeatedly acquire the same
row key again and again.
> So the optimization is to sort each batch operation based on the row key in the client
side, and skip acquiring the same row lock repeatedly in the server side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message