hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5257) Allow filter to be evaluated after version handling
Date Fri, 12 Oct 2012 04:39:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474779#comment-13474779
] 

ramkrishna.s.vasudevan commented on HBASE-5257:
-----------------------------------------------

+1.  I think some new JIRA also was raised for this.
I think filters like ColumnCountGetFilter or ColumnPagniation filter can be grouped to new
filter type and may be if the filterKeyValue of such filters return INCLUDE then the ColumnTrackers
should be considering this and then decide on filtering?

                
> Allow filter to be evaluated after version handling
> ---------------------------------------------------
>
>                 Key: HBASE-5257
>                 URL: https://issues.apache.org/jira/browse/HBASE-5257
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>
> There are various usecases and filter types where evaluating the filter before version
are handled either do not make sense, or make filter handling more complicated.
> Also see this comment in ScanQueryMatcher:
> {code}
>     /**
>      * Filters should be checked before checking column trackers. If we do
>      * otherwise, as was previously being done, ColumnTracker may increment its
>      * counter for even that KV which may be discarded later on by Filter. This
>      * would lead to incorrect results in certain cases.
>      */
> {code}
> So we had Filters after the column trackers (which do the version checking), and then
moved it.
> Should be at the discretion of the Filter.
> Could either add a new method to FilterBase (maybe excludeVersions() or something). Or
have a new Filter wrapper (like WhileMatchFilter), that should only be used as outmost filter
and indicates the same (maybe ExcludeVersionsFilter).
> See latest comments on HBASE-5229 for motivation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message