hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6949) Automatically delete empty directories in CleanerChore
Date Thu, 11 Oct 2012 07:11:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473906#comment-13473906
] 

stack commented on HBASE-6949:
------------------------------

I like this addition Jesse:

{code}
+    // if all the children have been deleted, then we should try to delete this directory.
However,
+    // don't do so recursively so we don't delete files that have been added since we checked.
{code}

The tests look good.

I'm not clear on this "...However, this leads to somewhat odd behavior in some delegates -
you don't actually care if the directory hierarchy is preserved, the files; this means you
always will delete directories and then implement the logic you actually want for preserving
files..."  I think I understand.  Delegates just do files and its the cleaner chore that does
the dir remove?  Is that it?
                
> Automatically delete empty directories in CleanerChore
> ------------------------------------------------------
>
>                 Key: HBASE-6949
>                 URL: https://issues.apache.org/jira/browse/HBASE-6949
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: hbase-6949-v0.patch, hbase-6949-v1.patch
>
>
> Currently the CleanerChore asks cleaner delegates if both directories and files should
be deleted. However, this leads to somewhat odd behavior in some delegates - you don't actually
care if the directory hierarchy is preserved, the files; this means you always will delete
directories and then implement the logic you actually want for preserving files. Instead we
can handle this logic one layer higher in the CleanerChore and let the delegates just worry
about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message