hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6597) Block Encoding Size Estimation
Date Fri, 19 Oct 2012 22:02:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480431#comment-13480431

Phabricator commented on HBASE-6597:

Kannan has commented on the revision "[jira] [HBASE-6597] [89-fb] Incremental data block encoding".

  comments thus far...

  src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java:445 mismath -> mismatch
  src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java:446 don't you need two
more %s's.
  src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java:132 shouldn't this be:

  if (length - offset < Bytes.SIZEOF_INT)

  src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java:29 I think
this comment is no longer valid.

  * It gets used for ENCODING => 'NONE' case now correct?
  * Wondering now, if that was a correct choice... because we seem to be having to jump through
some hoops to handle this encoder as a separate case (such as to not write the headers, etc.).


To: Kannan, Karthik, Liyin, aaiyer, avf, JIRA, mbautin
Cc: tedyu

> Block Encoding Size Estimation
> ------------------------------
>                 Key: HBASE-6597
>                 URL: https://issues.apache.org/jira/browse/HBASE-6597
>             Project: HBase
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.89-fb
>            Reporter: Brian Nixon
>            Assignee: Mikhail Bautin
>            Priority: Minor
>         Attachments: D5895.1.patch, D5895.2.patch, D5895.3.patch, D5895.4.patch
> Blocks boundaries as created by current writers are determined by the size of the unencoded
data. However, blocks in memory are kept encoded. By using an estimate for the encoded size
of the block, we can get greater consistency in size.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message