hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kumar Ravi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94
Date Mon, 22 Oct 2012 20:30:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481754#comment-13481754
] 

Kumar Ravi commented on HBASE-6945:
-----------------------------------

@stack, I was hoping we could address concerns in HBASE-6965, since this JIRA was riding on
that.

Here are my responses to your questions for this JIRA:

> We seem to be removing the body of the class.
 The functionality of this class is already there in the OSMXBean.  If this is going to be
an issue, we need to discuss the best approach about how to reorganize the classes. Most of
the APIs and methods in the above abstract classes access APIs and methods not available in
some JVMs.

>Should this class, OSMXBean, be renamed OS since it answers questions about the OS in
a way that insulates us against differences in JVM. 

 Do you mean OSBean instead of OSMXBean? I am open to renaming the class to  At this point,
OSMXBean has been committed to trunk though. If you could let me know how to back out the
patch now, I can do that. I would like to make sure we are in concurrence on the overall class
and the methods.

>Maybe a better name would be JVM. Then you'd ask it for an implementation of UnixOperatingSystemMXBean.
It would take care of returning the >IBM or Oracle implementation. They both implement
the UnixOperatingSystemMXBean Interface?

 I am not sure I follow. IBM Java will not be able to implement the UnixOperatingSystemMXBean
interface as the IBM Java SDK does not contain the com.sun.management package. OSMXBean acts
like a wrapper and invokes the UnixOperatingSystemMXBean if the JDK is Sun and for IBM provides
the equivalent functionality. 
                
> Compilation errors when using non-Sun JDKs to build HBase-0.94
> --------------------------------------------------------------
>
>                 Key: HBASE-6945
>                 URL: https://issues.apache.org/jira/browse/HBASE-6945
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.94.1
>         Environment: RHEL 6.3, IBM Java 7 
>            Reporter: Kumar Ravi
>            Assignee: Kumar Ravi
>              Labels: patch
>             Fix For: 0.94.3
>
>         Attachments: ResourceCheckerJUnitListener_HBASE_6945-trunk.patch
>
>
> When using IBM Java 7 to build HBase-0.94.1, the following comilation error is seen.

> [INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR : 
> [INFO] -------------------------------------------------------------
> [ERROR] /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
error: package com.sun.management does not exist
> [ERROR] /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
error: cannot find symbol
> [ERROR]   symbol:   class UnixOperatingSystemMXBean
>   location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
error: cannot find symbol
> [ERROR]   symbol:   class UnixOperatingSystemMXBean
>   location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
error: cannot find symbol
> [INFO] 4 errors 
> [INFO] -------------------------------------------------------------
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
>  I have a patch available which should work for all JDKs including Sun.
>  I am in the process of testing this patch. Preliminary tests indicate the build is working
fine with this patch. I will post this patch when I am done testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message