hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6721) RegionServer Group based Assignment
Date Wed, 24 Oct 2012 15:46:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483325#comment-13483325

Ted Yu commented on HBASE-6721:

+  public LoadBalancer getBalancer() {
+    return balancer;
+  }
The above method can be package private.
+public class GroupAdminEndpoint extends BaseEndpointCoprocessor implements GroupAdminProtocol,
EventHandler.EventHandlerListener {
+ private static final Log LOG = LogFactory.getLog(GroupAdminClient.class);
Please add javadoc for the class. The line is beyond 100 characters.
Log has wrong class.
+  private ConcurrentMap<String,String> serversInTransition =
What does the value in serversInTransition map represent ?
+   List<HRegionInfo> regions = new ArrayList<HRegionInfo>();
+   if (groupName == null) {
+      throw new NullPointerException("groupName can't be null");
nit: move ArrayList creation after the if statement.
+  public Collection<String> listTablesOfGroup(String groupName) throws IOException
The return type is a collection, more generic than List that listOnlineRegionsOfGroup() returns.
I guess there might be a reason.
+      HTableDescriptor[] tables = master.getTableDescriptors().getAll().values().toArray(new
nit: line too long.
+  public GroupInfo getGroup(String groupName) throws IOException {
Suggest renaming the method getGroupInfo(). getGroup() is kind of vague.

More reviews to follow.
> RegionServer Group based Assignment
> -----------------------------------
>                 Key: HBASE-6721
>                 URL: https://issues.apache.org/jira/browse/HBASE-6721
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Francis Liu
>            Assignee: Vandana Ayyalasomayajula
>             Fix For: 0.96.0
>         Attachments: HBASE-6721_94.patch, HBASE-6721_94.patch, HBASE-6721-DesigDoc.pdf
> In multi-tenant deployments of HBase, it is likely that a RegionServer will be serving
out regions from a number of different tables owned by various client applications. Being
able to group a subset of running RegionServers and assign specific tables to it, provides
a client application a level of isolation and resource allocation.
> The proposal essentially is to have an AssignmentManager which is aware of RegionServer
groups and assigns tables to region servers based on groupings. Load balancing will occur
on a per group basis as well. 
> This is essentially a simplification of the approach taken in HBASE-4120. See attached

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message