hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Chanan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4583) Integrate RWCC with Append and Increment operations
Date Tue, 30 Oct 2012 19:54:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487163#comment-13487163
] 

Gregory Chanan commented on HBASE-4583:
---------------------------------------

New test for increment looks good.  Should we have a similar one for append as well?

I also have the same question as Ted about "readpoint -1".

{code}
       // create or update (upsert) a new KeyValue with
       // 'now' and a 0 memstoreTS == immediately visible
       return upsert(Arrays.asList(
-          new KeyValue(row, family, qualifier, now, Bytes.toBytes(newValue)))
+          new KeyValue(row, family, qualifier, now, Bytes.toBytes(newValue))), 1L
{code}
it looks from here like we will never remove anything via updateColumnValue, because we would
need cur.getMemstoreTS() < readpoint - 1 => cur.getMemstoreTS() < 1-1 => cur.getMemstoreTS()
< 0?  Why do we pass 1 in the above?

I also notice in append/increment we call completeMemstoreInsert before we sync to the WAL,
while other calls like put do it after.  Is it safe to do it before?  Why doesn't put do it
that way, then?
                
> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>
>                 Key: HBASE-4583
>                 URL: https://issues.apache.org/jira/browse/HBASE-4583
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: 4583-trunk-less-radical.txt, 4583-trunk-less-radical-v2.txt, 4583-trunk-radical.txt,
4583-trunk-radical_v2.txt, 4583-trunk-v3.txt, 4583.txt, 4583-v2.txt, 4583-v3.txt, 4583-v4.txt
>
>
> Currently Increment and Append operations do not work with RWCC and hence a client could
see the results of multiple such operation mixed in the same Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes to and
from the memstore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message