hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6942) Endpoint implementation for bulk delete rows
Date Mon, 22 Oct 2012 16:46:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481491#comment-13481491
] 

Ted Yu commented on HBASE-6942:
-------------------------------

Please use remove the trailing CR (^M) in the patch.
Trunk patch looks good overall.
{code}
+public class BulkDeleteEndpoint extends BulkDeleteService implements CoprocessorService,^M
+    Coprocessor {^M
{code}
Please add javadoc to above class.
{code}
+          scanner.close();^M
+        } catch (IOException ioe) {^M
+          LOG.debug(ioe);^M
{code}
Should LOG.error() be used above ?
{code}
+            byte[] versionsDeleted = deleteWithLockArr[i].getFirst().getAttribute(^M
+                NO_OF_VERSIONS_TO_DELETE);^M
+            if (versionsDeleted != null) {^M
+              totalVersionsDeleted += Bytes.toInt(versionsDeleted);^M
+            }^M
{code}
Should the above be enclosed in if (deleteType == DeleteType.VERSION) block ?
{code}
+      h = h + 13 * Bytes.hashCode(this.family);^M
+      h = h + 13 * Bytes.hashCode(this.qualifier);^M
{code}
Would mulplication by 13 result in overflow ?
Take a look at the following code from HColumnDescriptor:
{code}
    result ^= Byte.valueOf(COLUMN_DESCRIPTOR_VERSION).hashCode();
    result ^= values.hashCode();
{code}
{code}
+ * Copyright 2011 The Apache Software Foundation^M
{code}
The above line is not needed.
                
> Endpoint implementation for bulk delete rows
> --------------------------------------------
>
>                 Key: HBASE-6942
>                 URL: https://issues.apache.org/jira/browse/HBASE-6942
>             Project: HBase
>          Issue Type: Improvement
>          Components: Coprocessors, Performance
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.94.3, 0.96.0
>
>         Attachments: HBASE-6942_DeleteTemplate.patch, HBASE-6942.patch, HBASE-6942_Trunk.patch,
HBASE-6942_V2.patch, HBASE-6942_V3.patch, HBASE-6942_V4.patch, HBASE-6942_V5.patch, HBASE-6942_V6.patch,
HBASE-6942_V7.patch
>
>
> We can provide an end point implementation for doing a bulk deletion of rows(based on
a scan) at the server side. This can reduce the time taken for such an operation as right
now it need to do a scan to client and issue delete(s) using rowkeys.
> Query like  delete from table1 where...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message