hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
Date Thu, 18 Oct 2012 23:52:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479497#comment-13479497
] 

stack commented on HBASE-7009:
------------------------------

This is probably not a good change for the third point release on 0.94:

{code}
-  exec "$JAVA" -XX:OnOutOfMemoryError="kill -9 %p" $JAVA_HEAP_MAX $HBASE_OPTS -classpath
"$CLASSPATH" $CLASS "$@"
+  exec "$JAVA" -Dproc_$COMMAND -XX:OnOutOfMemoryError="kill -9 %p" $JAVA_HEAP_MAX $HBASE_OPTS
-classpath "$CLASSPATH" $CLASS "$@"
{code}

Do you need the above getting the tests into 0.94?  It could be a little disturbing to folks
having their process listing different across a point release.

You fellas using this stuff now?  It is kind of a new feature.   Is it really needed back
in 0.94?  (It is also a large patch which would usually be a mark against our backporting
it but its nearly all test code so to my mind it gets a free pass)

Otherwise, on quick review, patch looks good... I don't see conflict other than that noted
above.


                
> Port HBaseCluster interface/tests to 0.94
> -----------------------------------------
>
>                 Key: HBASE-7009
>                 URL: https://issues.apache.org/jira/browse/HBASE-7009
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 0.94.3
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.94.3
>
>         Attachments: HBASE-7009-p1.patch, HBASE-7009.patch
>
>
> Need to port. I am porting V5 patch from the original JIRA; I have a partially ported
(V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message