hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7070) Scanner may retry forever after HBASE-5974
Date Wed, 31 Oct 2012 04:39:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487515#comment-13487515
] 

Ted Yu commented on HBASE-7070:
-------------------------------

2 * CLIENT_RETRIES_NUMBER appears twice in the patch, consider introducing a constant for
it.
{code}
+    assertTrue("Expected try number=" + CLIENT_RETRIES_NUMBER + ", actual ="
+        + RegionServerWithScanTimeout.tryNumber,
+        RegionServerWithScanTimeout.tryNumber <= 2 * CLIENT_RETRIES_NUMBER);
{code}
Expected try number is 2 * CLIENT_RETRIES_NUMBER, not CLIENT_RETRIES_NUMBER.
{code}
+    } catch (IOException ioe) {
+      // catch the exception after max retry number
{code}
Add a log in the catch block ?
                
> Scanner may retry forever  after HBASE-5974
> -------------------------------------------
>
>                 Key: HBASE-7070
>                 URL: https://issues.apache.org/jira/browse/HBASE-7070
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.96.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7070.patch, HBASE-7070v2.patch
>
>
> After the patch of HBASE-5974
> Suppose The process is as the following:
> 1.A next request is very large, so first time it is failed because of timeout
> 2.The second time it is failed again because of CallSequenceOutOfOrderException
> 3.We will retry this next request again after reset scanner, so it is also very large
and failed again because of timeout
> 4.CallSequenceOutOfOrderException again
> 5.Repeated the above forever...
> See the comment in HBASE-5974 for more
> https://issues.apache.org/jira/browse/HBASE-5974?focusedCommentId=13486658&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13486658

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message