hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7043) Region Server Group CLI commands
Date Thu, 25 Oct 2012 17:43:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484312#comment-13484312
] 

Sergey Shelukhin commented on HBASE-7043:
-----------------------------------------

It may be because my Ruby-fu is weak, but this doesn't look right:
{noformat}
          res[entry.getKey] ||= {}
          res[entry.getKey] = entry.getVal
{noformat}

Also, res is set in this and many similar places and not used.

Nit: footer count output is inconsistent (e.g. getGroup doesn't output it)

Nit #2: group_move_server should be called "...serverS" imho, and description updated accordingly.


Also the patch is for 0.94 but fixed version says 0.96. Is is this for 0.94?
                
> Region Server Group CLI commands
> --------------------------------
>
>                 Key: HBASE-7043
>                 URL: https://issues.apache.org/jira/browse/HBASE-7043
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Francis Liu
>            Assignee: Francis Liu
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7043_94.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message