hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6470) SingleColumnValueFilter with private fields and methods
Date Thu, 11 Oct 2012 03:49:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473816#comment-13473816

stack commented on HBASE-6470:

Change what you need to package private.  If you need access outside the package, add accessors.
 Thanks Benjamin.
> SingleColumnValueFilter with private fields and methods
> -------------------------------------------------------
>                 Key: HBASE-6470
>                 URL: https://issues.apache.org/jira/browse/HBASE-6470
>             Project: HBase
>          Issue Type: Improvement
>          Components: Filters
>    Affects Versions: 0.94.0
>            Reporter: Benjamin Kim
>              Labels: patch
>             Fix For: 0.94.3
> Why are most fields and methods declared private in SingleColumnValueFilter?
> I'm trying to extend the functions of the SingleColumnValueFilter to support complex
column types such as JSON, Array, CSV, etc.
> But inheriting the SingleColumnValueFilter doesn't give any benefits for I have to rewrite
the codes. 
> I think all private fields and methods could turn into protected mode.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message