hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6920) On timeout connecting to master, client can get stuck and never make progress
Date Wed, 03 Oct 2012 19:04:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468745#comment-13468745
] 

Lars Hofhansl commented on HBASE-6920:
--------------------------------------

Actually, let's just fix the issue you discovered here. +1 on your patch.
We can think about the other change I suggest for 0.94.3. It is time to get 0.94.2 out the
door.
                
> On timeout connecting to master, client can get stuck and never make progress
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-6920
>                 URL: https://issues.apache.org/jira/browse/HBASE-6920
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.2
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Critical
>             Fix For: 0.94.2
>
>         Attachments: HBASE-6920.patch, HBASE-6920-v2.patch
>
>
> HBASE-5058 appears to have introduced an issue where a timeout in HConnection.getMaster()
can cause the client to never be able to connect to the master.  So, for example, an HBaseAdmin
object can never successfully be initialized.
> The issue is here:
> {code}
> if (tryMaster.isMasterRunning()) {
>   this.master = tryMaster;
>   this.masterLock.notifyAll();
>   break;
> }
> {code}
> If isMasterRunning times out, it throws an UndeclaredThrowableException, which is already
not ideal, because it can be returned to the application.
>  But if the first call to getMaster succeeds, it will set masterChecked = true, which
makes us never try to reconnect; that is, we will set this.master = null and just throw MasterNotRunningExceptions,
without even trying to connect.
> I tried out a 94 client (actually a 92 client with some 94 patches) on a cluster with
some network issues, and it would constantly get stuck as described above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message