hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "liang xie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7014) cleanup 4 minor findbug warings
Date Mon, 22 Oct 2012 03:30:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481150#comment-13481150
] 

liang xie commented on HBASE-7014:
----------------------------------

[~saint.ack@gmail.com], sorry for late response:0
1) Before applied this patch, see "https://builds.apache.org/job/PreCommit-HBASE-Build/3087/console":
Found 494 Findbugs warnings (/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/target/findbugsXml.xml);
   After applied this patch, see "https://builds.apache.org/job/PreCommit-HBASE-Build/3088/console":
Found 490 Findbugs warnings (/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/target/findbugsXml.xml)

2) Here is the findbugs output that i was addressed :
output1
{quote}
Invocation of toString on tableName in org.apache.hadoop.hbase.security.access.AccessController.updateACL(RegionCoprocessorEnvironment,
Map)
Bug type DMI_INVOKING_TOSTRING_ON_ARRAY (click for details)
In class org.apache.hadoop.hbase.security.access.AccessController
In method org.apache.hadoop.hbase.security.access.AccessController.updateACL(RegionCoprocessorEnvironment,
Map)
Local variable named tableName
At AccessController.java:[line 239]
{quote}

output2
{quote}
BC 	instanceof will always return true in org.apache.hadoop.hbase.filter.ByteArrayComparable.areSerializedFieldsEqual(ByteArrayComparable),
since all org.apache.hadoop.hbase.filter.ByteArrayComparable are instances of org.apache.hadoop.hbase.filter.ByteArrayComparable
Bug type BC_VACUOUS_INSTANCEOF (click for details)
In class org.apache.hadoop.hbase.filter.ByteArrayComparable
In method org.apache.hadoop.hbase.filter.ByteArrayComparable.areSerializedFieldsEqual(ByteArrayComparable)
Actual type org.apache.hadoop.hbase.filter.ByteArrayComparable
Expected org.apache.hadoop.hbase.filter.ByteArrayComparable
At ByteArrayComparable.java:[line 80]
{quote}

output3:
{quote}
GC 	String is incompatible with expected argument type org.apache.hadoop.hbase.ServerName
in org.apache.hadoop.hbase.master.ServerManager.getServerConnection(ServerName)
Bug type GC_UNRELATED_TYPES (click for details)
In class org.apache.hadoop.hbase.master.ServerManager
In method org.apache.hadoop.hbase.master.ServerManager.getServerConnection(ServerName)
Actual type String
Expected org.apache.hadoop.hbase.ServerName
Called method java.util.Map.get(Object)
Invoked on org.apache.hadoop.hbase.master.ServerManager.serverConnections
String.equals(Object) used to determine equality
At ServerManager.java:[line 664]
{quote}

output4:
{quote}
ES 	Comparison of String objects using == or != in org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.logPositionAndCleanOldLogs(Path,
String, long, boolean, boolean)
Bug type ES_COMPARING_STRINGS_WITH_EQ (click for details)
In class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager
In method org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.logPositionAndCleanOldLogs(Path,
String, long, boolean, boolean)
Actual type String
Value loaded from key
Return value of java.util.SortedSet.first()
At ReplicationSourceManager.java:[line 161]
{quote}


                
> cleanup 4 minor findbug warings
> -------------------------------
>
>                 Key: HBASE-7014
>                 URL: https://issues.apache.org/jira/browse/HBASE-7014
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: liang xie
>            Assignee: liang xie
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7014.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message