hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5937) Refactor HLog into an interface.
Date Mon, 01 Oct 2012 17:13:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466953#comment-13466953
] 

stack commented on HBASE-5937:
------------------------------

bq. The splitter might not be necessary for every implementation, so I don't think it is a
good idea to make it part of HLog.

Its fine it doesn't need to split but Master needs some way of figuring that w/ a particular
implemenation, there is no need to split.  How will you do this?

bq. I can't remember now where I got it from, but it is used in TestHLogSplit only to reset
the class we use for the HLog reader. We have the ability to configure the class we use for
the reader and the writer.

If only for that test, I'd say we file an issue to fix this ugly addition to HLog only used
in a single test....

bq. Ok, thanks for the hint. I don't think I have added that statement, but I'm happy to change
it.

Not important.  Just an FYI.

bq. Are you suggesting that we make them static methods of say FSHLog instead of having them
in HLogUtil?

They seem to be me like they belong in the Interface... getReader... or, if FSHLog particular,
in FSHLog.

bq. The idea behind HLogUtil was to have all static methods in HLog originally.

To my mind, class named HLogUtil is utility that could be used by any HLog implementation.
 If that is not the case, call it FSHLogUtil?

You want to do your list in other JIRAs and get this patch committed now (do you want to do
one last update)?
                
> Refactor HLog into an interface.
> --------------------------------
>
>                 Key: HBASE-5937
>                 URL: https://issues.apache.org/jira/browse/HBASE-5937
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Flavio Junqueira
>            Priority: Minor
>         Attachments: 5937-hlog-with-javadoc.txt, HBASE-5937.patch, HBASE-5937.patch,
HBASE-5937.patch, HBASE-5937.patch, HBASE-5937.patch, org.apache.hadoop.hbase.client.TestMultiParallel-output.txt
>
>
> What the summary says. Create HLog interface. Make current implementation use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message