hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6950) TestAcidGuarantees system test now flushes too aggressively
Date Thu, 04 Oct 2012 22:31:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469788#comment-13469788
] 

Hadoop QA commented on HBASE-6950:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547827/HBASE-6950.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 81 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3008//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3008//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3008//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3008//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3008//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3008//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3008//console

This message is automatically generated.
                
> TestAcidGuarantees system test now flushes too aggressively
> -----------------------------------------------------------
>
>                 Key: HBASE-6950
>                 URL: https://issues.apache.org/jira/browse/HBASE-6950
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.92.2, 0.94.2, 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6950.patch
>
>
> HBASE-6552 caused the TestAcidGuarantees system test to flush more aggressively, because
flushes are where ACID problems have occurred in the past.
> After some more cluster testing, it seems like this too aggressive; my clusters eventually
can't keep up with the number of flushes/compactions and start getting SocketTimeoutExceptions.
 We could try to optimize the flushes/compactions, but since this workload would never occur
in practice, I don't think it is worth the effort.  Instead, let's just only flush once a
minute.  This is arbitrary, but seems to work.
> Here is my comment in the (upcoming) patch:
> {code}
> // Flushing has been a source of ACID violations previously (see HBASE-2856), so ideally,
> // we would flush as often as possible.  On a running cluster, this isn't practical:
> // (1) we will cause a lot of load due to all the flushing and compacting
> // (2) we cannot change the flushing/compacting related Configuration options to try
to
> // alleviate this
> // (3) it is an unrealistic workload, since no one would actually flush that often.
> // Therefore, let's flush every minute to have more flushes than usual, but not overload
> // the running cluster.
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message