Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E834D417 for ; Fri, 7 Sep 2012 23:51:08 +0000 (UTC) Received: (qmail 57478 invoked by uid 500); 7 Sep 2012 23:51:08 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 57351 invoked by uid 500); 7 Sep 2012 23:51:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 57341 invoked by uid 99); 7 Sep 2012 23:51:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Sep 2012 23:51:08 +0000 Date: Sat, 8 Sep 2012 10:51:08 +1100 (NCT) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <748851470.53247.1347061868097.JavaMail.jiratomcat@arcas> In-Reply-To: <1607302559.2232.1345838331263.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HBASE-6658) Rename WritableByteArrayComparable to something not mentioning Writable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451145#comment-13451145 ] Ted Yu commented on HBASE-6658: ------------------------------- See http://docs.oracle.com/javase/6/docs/api/java/util/Comparator.html While Comparable defines compareTo() method which is not in Comparator interface. I suggest keeping Comparable in class names and only dropping Writable. > Rename WritableByteArrayComparable to something not mentioning Writable > ----------------------------------------------------------------------- > > Key: HBASE-6658 > URL: https://issues.apache.org/jira/browse/HBASE-6658 > Project: HBase > Issue Type: Bug > Reporter: Gregory Chanan > Assignee: Gregory Chanan > Priority: Minor > Fix For: 0.96.0 > > Attachments: HBASE-6658.patch > > > After HBASE-6477, WritableByteArrayComparable will no longer be Writable, so should be renamed. > Current idea is ByteArrayComparator (since all the derived classes are *Comparator not *Comparable), but I'm open to suggestions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira