Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C03DDD6E for ; Tue, 11 Sep 2012 10:48:10 +0000 (UTC) Received: (qmail 96494 invoked by uid 500); 11 Sep 2012 10:48:10 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 96352 invoked by uid 500); 11 Sep 2012 10:48:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 96326 invoked by uid 99); 11 Sep 2012 10:48:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2012 10:48:08 +0000 Date: Tue, 11 Sep 2012 21:48:07 +1100 (NCT) From: "binlijin (JIRA)" To: issues@hbase.apache.org Message-ID: <584126632.62646.1347360488581.JavaMail.jiratomcat@arcas> In-Reply-To: <1235716446.62642.1347360187845.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (HBASE-6756) Move some logic out of the lock range in HRegion.internalPut MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] binlijin updated HBASE-6756: ---------------------------- Attachment: HBASE-6756-0.94.patch > Move some logic out of the lock range in HRegion.internalPut > ------------------------------------------------------------ > > Key: HBASE-6756 > URL: https://issues.apache.org/jira/browse/HBASE-6756 > Project: HBase > Issue Type: Improvement > Reporter: binlijin > Priority: Minor > Attachments: HBASE-6756-0.94.patch > > > Current in HRegion.internalPut > {code} > this.updatesLock.readLock().lock(); > checkFamilies(familyMap.keySet()); > checkTimestamps(familyMap, now); > updateKVTimestamps(familyMap.values(), byteNow); > ..... > this.updatesLock.readLock().unlock(); > {code} > > We can change it to > {code} > checkFamilies(familyMap.keySet()); > checkTimestamps(familyMap, now); > updateKVTimestamps(familyMap.values(), byteNow); > this.updatesLock.readLock().lock(); > ..... > this.updatesLock.readLock().unlock(); > {code} > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira