Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B9D8D4E1 for ; Wed, 19 Sep 2012 20:35:08 +0000 (UTC) Received: (qmail 36585 invoked by uid 500); 19 Sep 2012 20:35:08 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 36550 invoked by uid 500); 19 Sep 2012 20:35:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36541 invoked by uid 99); 19 Sep 2012 20:35:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2012 20:35:08 +0000 Date: Thu, 20 Sep 2012 07:35:08 +1100 (NCT) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: <429109029.99309.1348086908109.JavaMail.jiratomcat@arcas> In-Reply-To: <1016381475.16222.1346326688369.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459064#comment-13459064 ] stack commented on HBASE-6698: ------------------------------ That TestHRegion failure looks suspicious. Does this patch really introduce 14 findbugs issues (Its removing code mostly) > Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation > ------------------------------------------------------------------ > > Key: HBASE-6698 > URL: https://issues.apache.org/jira/browse/HBASE-6698 > Project: HBase > Issue Type: Improvement > Reporter: ramkrishna.s.vasudevan > Fix For: 0.96.0 > > Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_7.patch, HBASE-6698.patch > > > Currently the checkAndPut and checkAndDelete api internally calls the internalPut and internalDelete. May be we can just call doMiniBatchMutation > only. This will help in future like if we have some hooks and the CP > handles certain cases in the doMiniBatchMutation the same can be done while > doing a put thro checkAndPut or while doing a delete thro checkAndDelete. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira