Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 25 Sep 2012 07:58:07 +1100 (NCT)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1972063683.118650.1348520287661.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <1529174716.24751.1305761691368.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-3896) Make AssignmentManager standalone
 testable by having its constructor take Interfaces rather than a
 CatalogTracker and a ServerManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462114#comment-13462114 ] 

stack commented on HBASE-3896:
------------------------------

[~cody.marcel@gmail.com] This is done.  Check TestAssignmentManager.  See how it mocks up what AM needs.  Gets a bit messy around the rpc'ing.  If you have ideas on how to improve, please say.  Else, I think we can close this out.
                
> Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3896
>                 URL: https://issues.apache.org/jira/browse/HBASE-3896
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: Cody Marcel
>
> If we could stand up an instance of AssignmentManager, a core fat class that has a bunch of critical logic managing state transitions, then it'd be easier writing unit tests around its logic.  Currently its hard because it takes a ServerManager and a CatalogTracker, but a little bit of work could turn these into Interfaces.  SM looks easy to do.  Changing CT into an Interface instead might ripple a little through the code base but it'd probably be well worth it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira