Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 15 Sep 2012 12:15:07 +1100 (NCT)
From: "Gregory Chanan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1839480138.83378.1347671707971.JavaMail.jiratomcat@arcas>
In-Reply-To: <311900783.2226.1345838099759.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-6657) Merge Filter and FilterBase
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456272#comment-13456272 ] 

Gregory Chanan commented on HBASE-6657:
---------------------------------------

After looking at this again, I think I disagree with my initial assessment.  Even though Filter is now an abstract class, all of its methods are abstract, so have to be implemented.  That is, it behaves almost exactly like an interface.

So, I think it's still useful to have a FilterBase for default implementations.  I did notice that toByteArray is missing a default implementation in FilterBase. I'll add that in a different JIRA.
                
> Merge Filter and FilterBase
> ---------------------------
>
>                 Key: HBASE-6657
>                 URL: https://issues.apache.org/jira/browse/HBASE-6657
>             Project: HBase
>          Issue Type: Bug
>          Components: filters
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>
> After HBASE-6477, Filter is an abstract class, as is FilterBase.  It probably doesn't make much sense to keep both.
> See Review Request for more info:
> https://reviews.apache.org/r/6670/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira