Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 28 Sep 2012 05:49:07 +1100 (NCT)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1667508868.135091.1348771747913.JavaMail.jiratomcat@arcas>
In-Reply-To: <571283480.11761.1337783081093.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should
 log unsuccessful attempts and exceptions.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464972#comment-13464972 ] 

stack commented on HBASE-6071:
------------------------------

Patch looks fine.  I'd change the below to throw an InterruptedIOException:

{code}
+        logAndGiveUp(new IOException("Giving up after tries=" + tries, e), tries, exceptions);
{code}

... but I can do that on commit.

Are you running this change?  Does it work for you?
                
> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-6071
>                 URL: https://issues.apache.org/jira/browse/HBASE-6071
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, IPC/RPC
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Igal Shilman
>            Priority: Minor
>              Labels: client, ipc
>         Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch, HBASE-6071.v5.patch, HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
>
>
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E]) adding a log message inside the catch block describing the exception type and details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira